Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC#1074/backend/group-column-show-member #287

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

zingmane
Copy link
Member

@zingmane zingmane commented Aug 1, 2024

Submit a pull request

Please make sure the following is true

  • I gave the PR a meaningful name
  • I checked that the correct target branch is selected
  • I rebased the branch on the target branch and it can be merged
  • I ran the linter and it did pass
  • I checked for unused code / dead code / debug code
  • I checked that variables/functions have meaningful names
  • I checked that the behaviour is as the documentation/task describes and I tested it
  • I updated the docs / specifications if possible
  • I could explain all that code when someone wakes me up at 3am
  • I checked that the code considers failures and not just the happy path
  • There are no new dependencies OR I listed them and explained them below
  • PR introduces no breaking changes OR I listed them and described them below
  • I added/updated tests for new/modified unit-testable functions/helpers
  • I ran the tests and they did pass

Other information/comments (e.g. reasons why points are not checked from above)

https://app.activecollab.com/116706/projects/2/tasks/53860

Copy link

github-actions bot commented Aug 1, 2024

File Coverage
All files 87%
com/campudus/tableaux/exceptions.scala 0%
com/campudus/tableaux/exceptions.scala 0%
com/campudus/tableaux/arguments.scala 90%
com/campudus/tableaux/Starter.scala 79%
com/campudus/tableaux/cache/CacheVerticle.scala 77%
com/campudus/tableaux/cache/CacheClient.scala 63%
com/campudus/tableaux/controller/SystemController.scala 99%
com/campudus/tableaux/controller/TableauxController.scala 98%
com/campudus/tableaux/controller/StructureController.scala 91%
com/campudus/tableaux/controller/MediaController.scala 80%
com/campudus/tableaux/database/historyType.scala 7%
com/campudus/tableaux/database/languageType.scala 86%
com/campudus/tableaux/database/historyType.scala 66%
com/campudus/tableaux/database/database.scala 96%
com/campudus/tableaux/database/database.scala 81%
com/campudus/tableaux/database/database.scala 97%
com/campudus/tableaux/database/domain/column.scala 68%
com/campudus/tableaux/database/domain/column.scala 71%
com/campudus/tableaux/database/domain/column.scala 95%
com/campudus/tableaux/database/domain/table.scala 96%
com/campudus/tableaux/database/domain/service.scala 62%
com/campudus/tableaux/database/domain/service.scala 0%
com/campudus/tableaux/database/domain/column.scala 77%
com/campudus/tableaux/database/domain/annotation.scala 14%
com/campudus/tableaux/database/domain/column.scala 48%
com/campudus/tableaux/database/domain/annotation.scala 60%
com/campudus/tableaux/database/domain/history.scala 84%
com/campudus/tableaux/database/domain/column.scala 68%
com/campudus/tableaux/database/domain/column.scala 0%
com/campudus/tableaux/database/domain/annotation.scala 83%
com/campudus/tableaux/database/domain/annotation.scala 80%
com/campudus/tableaux/database/domain/table.scala 99%
com/campudus/tableaux/database/domain/column.scala 95%
com/campudus/tableaux/database/domain/file.scala 72%
com/campudus/tableaux/database/domain/domainobject.scala 99%
com/campudus/tableaux/database/domain/column.scala 92%
com/campudus/tableaux/database/domain/column.scala 78%
com/campudus/tableaux/database/domain/domainobject.scala 93%
com/campudus/tableaux/database/model/HistoryModel.scala 96%
com/campudus/tableaux/database/model/AttachmentModel.scala 82%
com/campudus/tableaux/database/model/TableauxModel.scala 91%
com/campudus/tableaux/database/model/StructureModel.scala 95%
com/campudus/tableaux/database/model/SystemModel.scala 85%
com/campudus/tableaux/database/model/FileModel.scala 94%
com/campudus/tableaux/database/model/structure/TableModel.scala 84%
com/campudus/tableaux/database/model/structure/TableGroupModel.scala 79%
com/campudus/tableaux/database/model/structure/ColumnModel.scala 89%
com/campudus/tableaux/database/model/structure/ColumnModel.scala 88%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 91%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 92%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 93%
com/campudus/tableaux/helper/FileUtils.scala 74%
com/campudus/tableaux/helper/JsonUtils.scala 94%
com/campudus/tableaux/helper/ResultChecker.scala 98%
com/campudus/tableaux/helper/IdentifierFlattener.scala 80%
com/campudus/tableaux/router/DocumentationRouter.scala 21%
com/campudus/tableaux/router/BaseRouter.scala 63%
com/campudus/tableaux/router/SystemRouter.scala 89%
com/campudus/tableaux/router/MediaRouter.scala 60%
com/campudus/tableaux/router/TableauxRouter.scala 82%
com/campudus/tableaux/router/StructureRouter.scala 99%
com/campudus/tableaux/router/RouterRegistry.scala 52%
com/campudus/tableaux/router/auth/KeycloakAuthHandler.scala 72%
com/campudus/tableaux/router/auth/permission/Condition.scala 89%
com/campudus/tableaux/router/auth/permission/Condition.scala 74%
com/campudus/tableaux/router/auth/permission/Condition.scala 87%
com/campudus/tableaux/router/auth/permission/RoleModel.scala 87%
com/campudus/tableaux/router/auth/permission/RoleModel.scala 0%
com/campudus/tableaux/router/auth/permission/Condition.scala 90%
com/campudus/tableaux/router/auth/permission/Condition.scala 79%
com/campudus/tableaux/router/auth/permission/Action.scala 97%
com/campudus/tableaux/router/auth/permission/Condition.scala 85%
com/campudus/tableaux/router/auth/permission/TableauxUser.scala 63%
com/campudus/tableaux/verticles/JsonSchemaValidator/JsonSchemaValidator.scala 86%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against fadd1c6

Copy link

github-actions bot commented Aug 1, 2024

Test Results

1 011 tests  +2   1 003 ✅ +2   2m 42s ⏱️ -16s
  124 suites ±0       8 💤 ±0 
  124 files   ±0       0 ❌ ±0 

Results for commit fadd1c6. ± Comparison against base commit 80be230.

♻️ This comment has been updated with latest results.

@zingmane zingmane merged commit f751ad2 into master Aug 2, 2024
11 checks passed
@zingmane zingmane deleted the AC#1074/backend/group-column-show-member branch August 2, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants