Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inclusive gateway is fully supported in 8.6 #1078

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: inclusive gateway is fully supported in 8.6 #1078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...g/camunda/community/migration/converter/visitor/impl/gateway/InclusiveGatewayVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

public class InclusiveGatewayVisitor extends AbstractGatewayVisitor {
private static final SemanticVersion FORK_AVAILABLE_VERSION = SemanticVersion._8_1;
private static final SemanticVersion JOIN_AVAILABLE_VERSION = SemanticVersion._8_6;
public static final String ELEMENT_LOCAL_NAME = "inclusiveGateway";

@Override
Expand All @@ -37,7 +38,7 @@ protected SemanticVersion availableFrom(DomElementVisitorContext context) {
if (isNotJoining(context.getElement())) {
return FORK_AVAILABLE_VERSION;
}
return null;
return JOIN_AVAILABLE_VERSION;
}

@Override
Expand Down
5 changes: 3 additions & 2 deletions ...erter/core/src/test/java/org/camunda/community/migration/converter/BpmnConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ void testOrGateways() {
assertThat(joinGateway.getMessages()).hasSize(1);
assertThat(joinGateway.getMessages().get(0).getMessage())
.isEqualTo(
"Element 'Inclusive Gateway' is not supported in Zeebe version '8.0.0'. Please review.");
"Element 'Inclusive Gateway' is not supported in Zeebe version '8.0.0'. It is available in version '8.6.0'.");
}

@Test
Expand All @@ -154,7 +154,8 @@ void testOrGateways_8_1() {
BpmnElementCheckResult joinGateway = result.getResult("JoinGateway");
assertThat(joinGateway.getMessages()).hasSize(1);
assertThat(joinGateway.getMessages().get(0).getMessage())
.isEqualTo("A joining inclusive gateway is not supported.");
.isEqualTo(
"Element 'Inclusive Gateway' is not supported in Zeebe version '8.1.0'. It is available in version '8.6.0'.");
}

@Test
Expand Down
Loading