Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hackdays #32

Merged
merged 53 commits into from
Oct 13, 2022
Merged

Hackdays #32

merged 53 commits into from
Oct 13, 2022

Conversation

pihme
Copy link
Collaborator

@pihme pihme commented Aug 10, 2022 •
edited
Loading

Here

  • as a reminder to review this in the end
  • to trigger CI pipeline on commit

closes: #38, #35, #31, #29, #28. #27, #26, #25, #24, #23, #20, #14, #13

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pihme
Copy link
Collaborator Author

pihme commented Aug 10, 2022

@vringar I guess you either need to get Camunda access to community hub org, or at least sign the CLA :-)

lenaschoenburg and others added 18 commits August 10, 2022 11:57
@pihme pihme marked this pull request as ready for review August 12, 2022 13:49
@pihme pihme requested a review from lenaschoenburg August 12, 2022 13:50
pihme
pihme commented Aug 19, 2022
View reviewed changes
Copy link
Collaborator Author

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve/reject the review because I created the PR. Overall, it's a request changes

README.md Outdated Show resolved Hide resolved
cli/src/activate_jobs.rs Outdated Show resolved Hide resolved
cli/src/cancel_process_instance.rs Show resolved Hide resolved
cli/src/complete_job.rs Show resolved Hide resolved
cli/src/create_process_instance.rs Show resolved Hide resolved
cli/src/set_variables.rs Show resolved Hide resolved
client/src/auth.rs Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
client/src/auth.rs Show resolved Hide resolved
client/src/lib.rs Outdated Show resolved Hide resolved
lenaschoenburg
lenaschoenburg approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet there are a lot of improvements we could make but code wise nothing stands out as something that we should fix before merging 🎉

@pihme pihme merged commit 295e420 into main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vringar vringar vringar left review comments

@lenaschoenburg lenaschoenburg lenaschoenburg approved these changes

Assignees

@lenaschoenburg lenaschoenburg

@vringar vringar

@pihme pihme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize CLI interface
4 participants
@pihme @CLAassistant @lenaschoenburg @vringar