Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth 8.7 migration linting: mixed-user-task-impl #178

Open
Skaiir opened this issue Oct 22, 2024 · 2 comments
Open

Smooth 8.7 migration linting: mixed-user-task-impl #178

Skaiir opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request rules

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Oct 22, 2024

Supports https://github.com/camunda/product-hub/issues/2126.

The rule should detect the following modeling patterns

Mixed use of job workers and zeebe user tasks

  • Incorrect
    <bpmn:userTask id="Activity_18h160l" name="Job worker">
    </bpmn:userTask>
    <bpmn:userTask id="Activity_18h160l" name="Job worker">
      <bpmn:extensionElements>
        <zeebe:userTask />
      </bpmn:extensionElements>
    </bpmn:userTask>

  • Correct
    <bpmn:userTask id="Activity_18h160l" name="Job worker">
    </bpmn:userTask>
    <bpmn:userTask id="Activity_18h160l" name="Job worker">
    </bpmn:userTask>

OR

    <bpmn:userTask id="Activity_18h160l" name="Job worker">
      <bpmn:extensionElements>
        <zeebe:userTask />
      </bpmn:extensionElements>
    </bpmn:userTask>
    <bpmn:userTask id="Activity_18h160l" name="Job worker">
      <bpmn:extensionElements>
        <zeebe:userTask />
      </bpmn:extensionElements>
    </bpmn:userTask>

How does the rule improve the BPMN diagram?

With the deprecation of user tasks soon, and since it can be generally challenging to mixed implementations, we should discourage it via warnings, but not outright error it as it somewhat supported (for now anyways).

Rule Details

  • Name: mixed-user-task-impl
  • Default notification level: error|warn|off

What alternatives did you consider?

n/a

@Skaiir
Copy link
Contributor Author

Skaiir commented Oct 22, 2024

@nikku
Copy link
Member

nikku commented Oct 30, 2024

@Skaiir I guess you'll still work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rules
Projects
None yet
Development

No branches or pull requests

2 participants