Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): allow querying for hist pis by async activities #4769

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Nov 5, 2024

related to #4757

Copy link
Member

@venetrius venetrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

Your changes to the unit tests have made them much simpler and easier to read. I learned a lot from reviewing them about writing clearer tests.

</foreach>
)
<if test="query.activityIds != null &amp;&amp; query.activityIds.length > 0">
${queryType} (EXE.IS_EVENT_SCOPE_ = ${falseConstant}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@tasso94 tasso94 merged commit fab8185 into master Nov 14, 2024
8 checks passed
@tasso94 tasso94 deleted the 4757-fix-hist-pis-query branch November 14, 2024 15:24
@ap-development-workflow
Copy link

Successfully created backport PR for 7.22:

  • camunda/camunda-bpm-platform-maintenance#1302

@tasso94
Copy link
Member Author

tasso94 commented Nov 14, 2024

/backport

@ap-development-workflow
Copy link

Git push to origin failed for 7.22 with exitcode 1

tasso94 added a commit to camunda/camunda-docs-manual that referenced this pull request Nov 14, 2024
ap-development-workflow bot pushed a commit to camunda/camunda-docs-manual that referenced this pull request Nov 14, 2024
tasso94 added a commit to camunda/camunda-docs-manual that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:backport:7.22 ci:all-db Runs the builds for all databases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants