Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release info to v5.30 #4713

Merged
merged 2 commits into from
Nov 22, 2024
Merged

chore: update release info to v5.30 #4713

merged 2 commits into from
Nov 22, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Nov 21, 2024

Proposed Changes

test

Related to #4691

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 21, 2024
@barmac barmac requested review from nikku, crobbins215, lmbateman, a team and abdul99ahad and removed request for a team November 21, 2024 10:39
@nikku nikku added this to the M83 milestone Nov 21, 2024
@nikku
Copy link
Member

nikku commented Nov 21, 2024

My questions:

  • Should we highlight the search improvements?
  • Should we highlight the core modeling (keyboard related) changes?

We could offer something like: "Various improvements to search".

@barmac
Copy link
Collaborator Author

barmac commented Nov 21, 2024

I think search makes sense, but I couldn't find any good message for keyboard binding. I know that it's useful for the developers, but what is the impact on the user? Do you have any suggestion?

@nikku
Copy link
Member

nikku commented Nov 21, 2024

I couldn't find any good message for keyboard binding.

Agreed that this is an implementation detail. We definitely want to give folks a heads up internally though (and we do also externally via the CHANGELOG).

@barmac
Copy link
Collaborator Author

barmac commented Nov 21, 2024

I couldn't find any good message for keyboard binding.

Agreed that this is an implementation detail. We definitely want to give folks a heads up internally though (and we do also externally via the CHANGELOG).

Yes, I will talk about this in the release presentation for sure.

@barmac barmac force-pushed the release-info-5-30 branch 2 times, most recently from d1ed769 to ceccbd5 Compare November 21, 2024 14:20
@barmac
Copy link
Collaborator Author

barmac commented Nov 21, 2024

I updated the release info so that search is included.

@barmac barmac marked this pull request as ready for review November 21, 2024 16:16
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 21, 2024
@nikku
Copy link
Member

nikku commented Nov 22, 2024

I'd frame the "more acurate search" as "improved search", because it was already "acurate" before, we wanted results to be more "relevant". Other than that, looks great to me!

@nikku
Copy link
Member

nikku commented Nov 22, 2024

Of course [q] is if we want to feature the "update available indicator". From what I understand you mentioned you don't want to feature it @barmac? Will be part of changelog anyway.

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

Of course [q] is if we want to feature the "update available indicator". From what I understand you mentioned you don't want to feature it @barmac? Will be part of changelog anyway.

The thing is if you update on time, you won't see the new button. There's also no way to demo it.

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

I've applied your suggestions, and will update the screenshot. Thank you!

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

I am merging this for the RC, but we can still comment and adjust
@lmbateman @crobbins215

@barmac barmac merged commit 8d6e3fc into develop Nov 22, 2024
12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 22, 2024
@barmac barmac deleted the release-info-5-30 branch November 22, 2024 08:49
@crobbins215
Copy link

Suggestions, some just minor, main one I feel more strongly about is canvas search. I'm not keen on "Find more things"

Support for task listeners in Camunda 8
Define user task listeners in your Camunda 8.7 diagrams, with helpful guidance provided every step of the way.

Enhanced variables panel
Quickly access the variables panel from the application footer or toggle it using a keyboard shortcut.

Improved on canvas search
Locate elements and details more efficiently within BPMN diagrams, thanks to upgraded search and filtering capabilities.

Bug fixes and enhancements
This release includes bug fixes and additional minor improvements to enhance your experience.

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

Let me have a screenshot with your suggestions

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

@crobbins215 suggestions:

_Users_maciej_workspace_bpmn-io_camunda-modeler_client_build_index html

@barmac barmac mentioned this pull request Nov 22, 2024
4 tasks
@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

I opened a PR for update: #4716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants