Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCKs CI convention: single-rock repositories should include a subfolder for their rock #52

Open
orfeas-k opened this issue Mar 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@orfeas-k
Copy link
Contributor

The way ROCKs CI is designed right now implies that it doesn't work (as it should) for single-rock repository structure where the rockcraft.yaml file is placed in the repo's parent directory (example).

How ROCKs CI works

  • Get all directories containing a rockcraft.yaml file
  • Look for changes in that directory (including subdirectories)
  • Trigger the build-scan-test ci if there are changes.

This means that it will trigger the workflow and rebuild the rock for changes to any file in the repo.

Solution

Since during discussions with the team, we agreed that we prefer single-rock repositories to include a subfolder for their rock (example), then we can:

  1. Take this convention into consideration when creating spec for the CI Create a spec for ROCKs CI #48
  2. Document that this is how it works explicitly Create documentation for reusable ROCKs CI #47
  3. Restructure any rock repository not following the agreed structure.
@orfeas-k orfeas-k added the enhancement New feature or request label Mar 28, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5495.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant