New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add on pull request and on push workflows #9

Merged

NohaIhab merged 2 commits into main from kf-5225-add-workflows

Mar 28, 2024

Contributor

NohaIhab commented Mar 28, 2024 •

edited

Loading

Closes #7
Moves the rockcraft project to a new subdirectory /metacontroller due to canonical/charmed-kubeflow-workflows#52

NOTE this PR's CI will fail until all rockcraft projects in this repo have the following:

An up to date rockcraft file with the latest supported format (i.e. base and version must be valid)
Each rockcraft project directory must have a tox.ini file with envlist = pack, export-to-docker, sanity, integration. Example here.
Each rockcraft project directory must have a tests/ directory with sanity tests inside. Example here.


          feat: add on pull request and on push workflows

6543da3

NohaIhab requested a review from a team as a code owner

March 28, 2024 10:39


          fix: move rockcraft project to subdirectory

dee0b07

orfeas-k approved these changes

View reviewed changes

NohaIhab merged commit 23e4448 into main

6 of 7 checks passed

kimwnasptd deleted the kf-5225-add-workflows branch

March 28, 2024 12:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet