Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to enable automatic vulnerability reports #72

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Oct 9, 2024

This re-usable workflow can be used for reporting security vulnerabilities via Github issues. It takes the issue title, image-name, and issue-labels as inputs, and in turn:

  • edits an existing issue with the same title and updates the vulnerability report
  • creates a new issue with the issue-title and adds the vulnerability report in the description

Please NOTE this workflow assumes the existence of vulnerability reports as artefacts of a workflow run; that is, it expects artefacts named trivy-report- to be present in the sabe workflow run.

Part of #69

For reviewers

This workflow has been tested in this fork. The re-usable workflow is capable of generating these type of issues. Please note how they are edited if the Scan images workflow is run multiple times.
The workflow that generated those can be found here, and the re-usable workflow that is mentioned there is fully implemented in #73.

This re-usable workflow can be used for reporting security vulnerabilities
via Github issues. It takes the issue title, image-name, and issue-labels as
inputs, and in turn:
* edits an existing issue with the same title and updates the vulnerability report
* creates a new issue with the issue-title and adds the vulnerability report in the description

Please NOTE this workflow assumes the existence of vulnerability reports as artefacts
of a workflow run; that is, it expects artefacts named trivy-report-<image-name> to
be present in the sabe workflow run.

Part of #69
@DnPlas DnPlas requested a review from a team as a code owner October 9, 2024 01:47
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, I like the result. Left some comments

.github/workflows/report-vulnerability-in-gh.yaml Outdated Show resolved Hide resolved
.github/workflows/report-vulnerability-in-gh.yaml Outdated Show resolved Hide resolved
.github/workflows/report-vulnerability-in-gh.yaml Outdated Show resolved Hide resolved
.github/workflows/report-vulnerability-in-gh.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to comments, I think we need one or two small updates, other than that LGTM

@DnPlas DnPlas merged commit a4e604c into KF-6331-dev-branch Oct 11, 2024
@DnPlas DnPlas deleted the KF-6331-report-vulns-as-github-issues branch October 11, 2024 14:27
DnPlas added a commit that referenced this pull request Oct 15, 2024
feat: report vulnerabilities as GH issues and scan images from registry 

This commit adds:

* ci: add re-usable workflow for scans from published img and automatic… (ci: add re-usable workflow for scans from published img and automatic… #73)
* ci: add workflow to enable automatic vulnerability reports (ci: add workflow to enable automatic vulnerability reports #72)
* chore, ci: bump artifact download/upload and checkout actions v3 -> v4 (chore, ci: bump artifact download/upload and checkout actions v3 -> v4 #71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants