Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pull_request_template.md #58

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Create pull_request_template.md #58

merged 3 commits into from
Jun 6, 2024

Conversation

farshidtz
Copy link
Member

No description provided.

@farshidtz farshidtz requested a review from a team June 5, 2024 12:42
@farshidtz farshidtz marked this pull request as ready for review June 5, 2024 12:43
locnnil
locnnil reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@locnnil locnnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall structure is great. I've added one minor suggestion.

.github/pull_request_template.md Outdated Show resolved Hide resolved
jpm-canonical
jpm-canonical approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@jpm-canonical jpm-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good enough for now. We can change it over time as we figure out what is required, or as requirements change.

.github/pull_request_template.md Outdated Show resolved Hide resolved
locnnil
locnnil approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@locnnil locnnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@farshidtz farshidtz merged commit ddfeed0 into main Jun 6, 2024
1 of 4 checks passed
@farshidtz farshidtz deleted the pr-template branch June 6, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpm-canonical jpm-canonical jpm-canonical approved these changes

@locnnil locnnil locnnil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farshidtz @locnnil @jpm-canonical