Dumps logs even if test failed

[jpm-canonical]

Summary

Affected:

• Solves Thread tests: dump logs to file #75

Dump journal entries for snaps in test cleanup, after uninstall. This allows logs to be dumped, even if the tests failed.

Testing Steps

Check that log files are written even if tests fail:

• Set the LOCAL_INFRA_IF value to something that does not exist
• Set the REMOTE_INFRA_IF value to something that does not exist

[farshidtz]

I think we'll have much more readable logs if we dump them before the removal. The shutdown logic results in a lot of output that is irrelevant to the failure, making it hard to pinpoint the actual error.

[jpm-canonical]

My approach here was to log as much as possible. In case something went wrong, we have everything logged, and nothing missing. With that in mind I thought logging the installation and removal was a good idea.

Thinking about it, when we look at the logs it is because something failed, which is unlikely to be the removal. We want to see the failure's logs. The chance of the removal failing is slim, and even if removal fails, something else would have likely failed before that.

So I see your point, and agree that adding the removal logs could obfuscate the actual failure. I'll change it to dump the logs before removal.