tests: pin deployed charms to a latest and stable compatible version #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other constants from a constants.py file Part of canonical/bundle-kubeflow#863
DnPlas
force-pushed
the
KF-5537-pin-charm-deps-in-main
branch
from
503e82d to
aec4ad6
Compare
misohu
reviewed
Apr 16, 2024
tests/integration/test_charm.py
Outdated
| KUBEFLOW_DASHBOARD_TRUST = True | ||
|
|
||
| PROMETHEUS_K8S = "prometheus-k8s" | ||
| PROMETHEUS_K8S_CHANNEL = "1.0/stable" |
There was a problem hiding this comment.
Should not this be latest/stable?
There was a problem hiding this comment.
Whoops, sorry, I just copy pasted. Will update.
tests/integration/test_charm.py
Outdated
| PROMETHEUS_K8S_CHANNEL = "1.0/stable" | ||
| PROMETHEUS_K8S_TRUST = True | ||
| GRAFANA_K8S = "grafana-k8s" | ||
| GRAFANA_K8S_CHANNEL = "1.0/stable" |
There was a problem hiding this comment.
Should not this be latest/stable?
tests/integration/test_charm.py
Outdated
| GRAFANA_K8S_CHANNEL = "1.0/stable" | ||
| GRAFANA_K8S_TRUST = True | ||
| PROMETHEUS_SCRAPE_K8S = "prometheus-scrape-config-k8s" | ||
| PROMETHEUS_SCRAPE_K8S_CHANNEL = "1.0/stable" |
There was a problem hiding this comment.
Should not this be latest/stable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
Part of canonical/bundle-kubeflow#863