feat: add dex_oidc_config library #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a library to handle the dex-oidc-config relation interface. This library allows dex-auth to share its OIDC configuration with OIDC clients such as the oidc-gatekeeper charm. The library is designed to be extended to share any information about Dex, but right now it is only sharing Dex's issuer url. Closes #203
rgildein
reviewed
Jul 12, 2024
|
I manualy tested the functionality and it's working as expected. How I tested it: # for dex-auth-operator
$ git checkout KF-5966-create-issuer-interface
$ git merge KF-5967-remove-public-url-config
$ charmcraft pack
$ juju refresh dex-auth --path ./dex-auth_ubuntu-20.04-amd64.charm --force-units
$ juju deploy ./dex-auth_ubuntu-20.04-amd64.charm --resource oci-image=charmedkubeflow/dex:2.39.1-a91817e
# oidc-gatekeeper-operator
$ git checkout KF-5968-integrate-with-dex-oidc-config
# I commented line 73, so `# self._check_public_url()`, to avoid charm being in block state
$ charmcraft pack
$ juju deploy ./oidc-gatekeeper_ubuntu-20.04-amd64.charm --resource oci-image=charmedkubeflow/oidc-authservice:ckf-1.8-58e8217
# oidc-gatekeeper is in blocked state
$ juju status oidc-gatekeeper
...
oidc-gatekeeper/0* blocked idle 10.1.23.248 Missing relation with a Dex OIDC config provider. Please add the missing relation.
# add relation
$ juju integrate oidc-gatekeeper:oidc-provider-info dex-auth:dex-oidc-config
$ juju show-unit oidc-gatekeeper/0 --endpoint oidc-provider-info --app
oidc-gatekeeper/0:
opened-ports: []
charm: local:focal/oidc-gatekeeper-0
leader: true
life: alive
relation-info:
- relation-id: 1
endpoint: oidc-provider-info
related-endpoint: dex-oidc-config
application-data:
issuer-url: http://dex-auth.kf-5966.svc:5556/dex
provider-id: oidc-gatekeeper-0
address: 10.1.23.248 |
rgildein
reviewed
Jul 15, 2024
This was referenced Jul 22, 2024
DnPlas
added a commit
that referenced
this pull request
Jul 24, 2024
* feat: add dex_oidc_config library Add a library to handle the dex-oidc-config relation interface. This library allows dex-auth to share its OIDC configuration with OIDC clients such as the oidc-gatekeeper charm. The library is designed to be extended to share any information about Dex, but right now it is only sharing Dex's issuer url. Closes #203
DnPlas
added a commit
that referenced
this pull request
Jul 25, 2024
This branch introduces changes to support the dex-oidc-config interface and the deprecation of public-url in favour of issuer-url. For more information, please refer to the following: * refactor: add dex-issuer-url and remove public-url config options (#209) * feat: add dex_oidc_config library (#208) * chore: keep public-url config option for compatibility #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a library to handle the dex-oidc-config relation interface. This library allows dex-auth to share its OIDC configuration with OIDC clients such as the oidc-gatekeeper charm. The library is designed to be extended to share any information about Dex, but right now it is only sharing Dex's issuer url.
Closes #203
Testing instructions
public-urloidc-gatekeeper-operator#163juju show-unit oidc-gatekeeper. There should be thedex-issuer-urlvalue.