Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set charm to waitingStatus if missing ingress auth data #342

Merged
merged 3 commits into from
Nov 21, 2023
Merged

fix: set charm to waitingStatus if missing ingress auth data #342

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c74162c
fix: set charm to waitingStatus if missing ingress auth data
DnPlas Oct 6, 2023
a369a5a
Add unit tests
orfeas-k Oct 30, 2023
d3a1eee
Formar and fix lint
orfeas-k Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charms/istio-pilot/src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,10 @@ def _get_ingress_auth_data(self, event) -> dict:
if app != self.app
}

# Go into waiting status if there is no ingress-auth data
if not ingress_auth_data:
raise ErrorWithStatus("Waiting for the auth provider data.", WaitingStatus)

# We only support a single ingress-auth relation, so we can unpack and return just the
# contents
if len(ingress_auth_data) > 1:
Expand Down
Loading