Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cherry-pick): set charm to waitingStatus if missing ingress auth data (#342) #348

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix(cherry-pick): set charm to waitingStatus if missing ingress auth data (#342) #348

merged 2 commits into from
Nov 21, 2023

Conversation

orfeas-k
Copy link
Contributor

  • fix: set charm to waitingStatus if missing ingress auth data
  • Add unit tests

@DnPlas @orfeas-k
fix: set charm to waitingStatus if missing ingress auth data (#342)
96a0c66 
* fix: set charm to waitingStatus if missing ingress auth data

* Add unit tests

---------

Co-authored-by: Orfeas Kourkakis <[email protected]>
@orfeas-k orfeas-k requested a review from a team as a code owner November 21, 2023 08:29
@orfeas-k orfeas-k mentioned this pull request Nov 21, 2023
Closed
8 tasks
DnPlas
DnPlas approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orfeas-k LGTM

@orfeas-k orfeas-k merged commit f5c8055 into main Nov 21, 2023
17 checks passed
@orfeas-k orfeas-k deleted the kf-4482-forward-port branch November 21, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orfeas-k @DnPlas