Add patches for Kubernetes 1.32 #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaudetcobello
approved these changes
Nov 28, 2024
HomayoonAlimohammadi
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Thanks a lot, great work @bschimke95! LGTM. Applied the patches manually to Kubernetes v1.32.0-rc.0 and everything seems correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adapt the patches to the 1.32 release
Rationale
We slightly modify the upstream Kubernetes for various reasons. Those patches are applied on build and can be found in
build-scripts/components/kubernetes/patches/<release>.The patches might - as in this case - need to be adapted to fit the refactored code in new releases hence we need a folder for each release.
Testing
See #837 for a run with the latest 1.32-rc