-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5355] Deployment docs for AKS + EKS #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty good but some changes needed here and there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we implement similar suggestions to the canonical/kafka-operator#256 PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Especially with these note blocks. Made a few suggestions to improve. Nothing blocking.
Create an IAM account (or use legacy access keys) and login to AWS: | ||
|
||
```shell | ||
> aws configure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a biggie, but can we fix the usage of the prompt for combining input and output here, since we do it everywhere else? As far as I can see this is the last place to fix it (remove the >
and split output from input with proper introduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually purposely didn't want to do that since it is not JUST output. The lines below should also provide guidance on how to feed the inputs (although I know it is obvious), and we actually use placeholder instead of just taking the output of a screen
Co-authored-by: Vladimir Izmalkov <[email protected]>
Content copy and pasted to Discourse. This PR is superseded by #155 |
Deployment docs for Azure AKS, taked and readapted from https://discourse.charmhub.io/t/topic/14307