[DPE-2366][DPE-2365] HA tests #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusebio
requested changes
Sep 7, 2023
There was a problem hiding this comment.
I believe we need to address a couple of items before re-reviewing:
- Checks write more stringengly using offsets (to actually make sure broker are still writing data)
- Refactor the "kill leader" tests to actually make sure we test HA and that a new election went through
deusebio
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Great work Raul! I really like the new structure with the continuous write fixture. The tests is now way more reliable, accurate and effective.
Many thanks to @Mehdi-Bendriss also for sharing the structuring and the code in opensearch.
I have just a few small comments still attached but I feel we are closing this stuff nicely and swiftly!
Mehdi-Bendriss
approved these changes
Sep 13, 2023
| self._queue.close() | ||
| self._is_stopped = True | ||
|
|
||
| def _client(self): |
There was a problem hiding this comment.
nit: this could perhaps be externalized in a helper, so it can be called from the _run._client() function without having to duplicate it
zmraul
added a commit
that referenced
this pull request
Sep 27, 2023
* add two cluster ha test * restructure tests pipeline * add continuous writes structure * add delay to restart
zmraul
added a commit
that referenced
this pull request
Oct 17, 2023
* add two cluster ha test * restructure tests pipeline * add continuous writes structure * add delay to restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some boilerplate and HA tests.
test_second_cluster: Deploy two kafka/zk clusters and check that messages produced on one of them are not replicated to the second one.test_replicated_events: Check that a topic (with replication_factor=3) is replicated on the 3 instances. Note: since by default all reads also go to the leader, to check replication we read directly the persisted logs with the topic information.test_remove_topic_leader: Kill topic leader broker and check that messages can still be produced.Note: most of the code from
ha_helpers.pyis copied from general tests, so in-depth review is not needed.