Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5611] Remove cruise-control metrics reporter if no balancer #250

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Oct 7, 2024

Changes:

  • Set package mode to false in pyproject.toml. This will prevent poetry from emitting a warning every time we use the install subcommand
  • The properties related to Cruise Control are now set only if we run the balancer workload in the application or if we use the peer-cluster relation. This will prevent the broker from spamming the logs with warnings in simple deployments

I'll keep this PR as a draft until #244 is merged, as we'll need to update the relation name in the condition

Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Seems pretty straightforward!

@Batalex Batalex marked this pull request as ready for review October 20, 2024 17:25
src/managers/config.py Outdated Show resolved Hide resolved
@Batalex Batalex merged commit 07be36c into main Oct 30, 2024
21 checks passed
@Batalex Batalex deleted the feat/dpe-5611-cc-metrics branch October 30, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants