Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5553] feat: Don't restart server on keystore/truststore updates #272

Merged
merged 5 commits into from
Nov 25, 2024
Merged

[DPE-5553] feat: Don't restart server on keystore/truststore updates #272

merged 5 commits into from
Nov 25, 2024

Conversation

imanenami
Copy link
Contributor

@imanenami imanenami commented Nov 12, 2024 •
edited
Loading

Changes

  • Added truststore dynamic reload functionality using kafka-configs utility to reload truststore without broker restart
  • Added integration test for truststore dynamic reload functionality

@imanenami imanenami force-pushed the dpe-5553 branch 2 times, most recently from e1e696f to afa5abc Compare November 12, 2024 16:42
@imanenami imanenami changed the title [DPE-5553] feat: Don't restart server on keystore/truststore updates … [DPE-5553] feat: Don't restart server on keystore/truststore updates Nov 13, 2024
marcoppenheimer
marcoppenheimer reviewed Nov 13, 2024
View reviewed changes
src/core/cluster.py Show resolved Hide resolved
src/events/tls.py Outdated Show resolved Hide resolved
src/managers/tls.py Outdated Show resolved Hide resolved
src/managers/tls.py Outdated Show resolved Hide resolved
tests/integration/test_tls.py Outdated Show resolved Hide resolved
tests/integration/test_tls.py Outdated Show resolved Hide resolved
tests/integration/test_tls.py Show resolved Hide resolved
Batalex
Batalex requested changes Nov 13, 2024
View reviewed changes
src/events/tls.py Show resolved Hide resolved
tests/integration/helpers.py Show resolved Hide resolved
tests/integration/test_tls.py Outdated Show resolved Hide resolved
@marcoppenheimer
Copy link
Contributor

@imanenami - I think this needs to be rebased on main, could you let us know when that's done and we can get this merged asap :).
In turn, could you also open a duplicate PR on the Kafka K8s repo, so that they're in line?

@imanenami
Copy link
Contributor Author

@imanenami - I think this needs to be rebased on main, could you let us know when that's done and we can get this merged asap :). In turn, could you also open a duplicate PR on the Kafka K8s repo, so that they're in line?

Thanks Marc, I did the rebase, and sure, I'll do the k8s side too 👍

Batalex
Batalex reviewed Nov 25, 2024
View reviewed changes
src/events/tls.py Outdated Show resolved Hide resolved
@marcoppenheimer marcoppenheimer merged commit 650bbe3 into canonical:main Nov 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Batalex Batalex Batalex approved these changes

@marcoppenheimer marcoppenheimer marcoppenheimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imanenami @marcoppenheimer @Batalex