ci, fix: change profile of mysql-k8s to testing, skip artefact collec…

…tion on success (#624) * ci, fix: change profile of mysql-k8s to testing The mysql-k8s charm, used as kfp-db, has a profile configuration option that can be set to testing which sets the scope of deployment. This is recommended for testing environments with limited memory/disk. * ci: skip collection of debug artefacts on success The Github runners for the KFP CI are getting out of storage by the time the tests execution finishes, so there is no space left for saving logs. Skipping saving the debug artefacts on success will allow the workflows to run successfully.
canonical · Nov 27, 2024 · 8523e2e · 8523e2e
1 parent ce099b7
commit 8523e2e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml
@@ -179,6 +179,8 @@ jobs:
         run: juju status
         if: failure()
 
+      # Collect debug artefacts only on failure || cancelled as the CI for this repository
+      # in particular struggles with storage limitations.
       - name: Collect charm debug artifacts
         uses: canonical/kubeflow-ci/actions/dump-charm-debug-artifacts@main
-        if: always()
+        if: failure() || cancelled()
diff --git a/tests/integration/bundles/kfp_1.8_stable_install.yaml.j2 b/tests/integration/bundles/kfp_1.8_stable_install.yaml.j2
@@ -4,7 +4,6 @@ applications:
   argo-controller:         { charm: ch:argo-controller, channel: 3.3.10/stable, scale: 1, trust: true }
   metacontroller-operator: { charm: ch:metacontroller-operator, channel: 3.0/stable, scale: 1, trust: true }
   minio:                   { charm: ch:minio, channel: ckf-1.8/stable,       scale: 1 }
-  kfp-db:                  { charm: ch:mysql-k8s, channel: 8.0/stable, scale: 1, constraints: mem=2G, trust: true }
   mlmd:                    { charm: ch:mlmd, channel: 1.14/stable, scale: 1 }
   envoy:                   { charm: ch:envoy, channel: 2.0/stable, scale: 1 }
   kubeflow-profiles:       { charm: ch:kubeflow-profiles, channel: 1.8/stable, scale: 1, trust: true }
@@ -22,6 +21,13 @@ applications:
     options:
       default-gateway: kubeflow-gateway
     trust: true
+  kfp-db:
+    charm: mysql-k8s
+    channel: 8.0/stable
+    scale: 1
+    options:
+      profile: testing
+    trust: true
   kubeflow-roles:
     charm: kubeflow-roles
     channel: 1.8/stable

diff --git a/tests/integration/bundles/kfp_latest_edge.yaml.j2 b/tests/integration/bundles/kfp_latest_edge.yaml.j2
@@ -4,7 +4,6 @@ applications:
   argo-controller:         { charm: ch:argo-controller, channel: latest/edge, scale: 1, trust: true }
   metacontroller-operator: { charm: ch:metacontroller-operator, channel: latest/edge, scale: 1, trust: true }
   minio:                   { charm: ch:minio, channel: latest/edge,       scale: 1 }
-  kfp-db:                  { charm: ch:mysql-k8s, channel: 8.0/stable, scale: 1, constraints: mem=2G, trust: true }
   mlmd:                    { charm: ch:mlmd, channel: latest/edge, scale: 1, trust: true}
   envoy:                   { charm: ch:envoy, channel: latest/edge, scale: 1 }
   kubeflow-profiles:       { charm: ch:kubeflow-profiles, channel: latest/edge, scale: 1, trust: true }
@@ -22,6 +21,13 @@ applications:
     options:
       default-gateway: kubeflow-gateway
     trust: true
+  kfp-db:
+    charm: mysql-k8s
+    channel: 8.0/stable
+    scale: 1
+    options:
+      profile: testing
+    trust: true
   kubeflow-roles:
     charm: kubeflow-roles
     channel: latest/edge