Skip to content

Commit

Permalink
Added tensorboard-controller (#114)
Browse files Browse the repository at this point in the history
* Added `tensorboard-controller`

* fixed version

* refactored
  • Loading branch information
TakoB222 authored Aug 5, 2024
1 parent 9c8b687 commit 4684e55
Show file tree
Hide file tree
Showing 3 changed files with 158 additions and 0 deletions.
52 changes: 52 additions & 0 deletions tensorboard-controller/rockcraft.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Source https://github.com/kubeflow/kubeflow/blob/v1.9.0/components/tensorboard-controller/Dockerfile
name: tensorboard-controller
summary: An image for tensorboard controller
description: |
This image is used as part of the Charmed Kubeflow product. The controller needs
for providing the measurements and visualizations needed during the machine learning workflow.
version: "1.9.0"
license: Apache-2.0
base: [email protected]
services:
tensorboard-controller:
override: replace
summary: "tensorboard-controller service"
startup: enabled
user: ubuntu
command: "tensorboard-controller"
platforms:
amd64:

parts:
security-team-requirement:
plugin: nil
override-build: |
mkdir -p ${CRAFT_PART_INSTALL}/usr/share/rocks
(echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && \
dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > \
${CRAFT_PART_INSTALL}/usr/share/rocks/dpkg.query
tensorboard-controller:
plugin: go
source: https://github.com/kubeflow/kubeflow
source-type: git
source-tag: v1.9.0
source-subdir: components/tensorboard-controller
build-snaps:
- go/1.21/stable
build-packages:
- apt
- bash
build-environment:
- CGO_ENABLED: 0
- GOOS: linux
stage-packages:
- bash

non-root-user:
plugin: nil
after: [tensorboard-controller]
overlay-script: |
# Create a user in the $CRAFT_OVERLAY chroot
groupadd -R $CRAFT_OVERLAY -g 1001 ubuntu
useradd -R $CRAFT_OVERLAY -M -r -u 1001 -g ubuntu ubuntu
55 changes: 55 additions & 0 deletions tensorboard-controller/tests/test_rock.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.
#
#

from pathlib import Path

import os
import logging
import random
import pytest
import string
import subprocess
import yaml

from charmed_kubeflow_chisme.rock import CheckRock


@pytest.fixture()
def rock_test_env(tmpdir):
"""Yields a temporary directory and random docker container name, then cleans them up after."""
container_name = "".join(
[str(i) for i in random.choices(string.ascii_lowercase, k=8)]
)
yield tmpdir, container_name

try:
subprocess.run(["docker", "rm", container_name])
except Exception:
pass
# tmpdir fixture we use here should clean up the other files for us


@pytest.mark.abort_on_fail
def test_rock(rock_test_env):
"""Test rock."""
temp_dir, container_name = rock_test_env
check_rock = CheckRock("rockcraft.yaml")
rock_image = check_rock.get_name()
rock_version = check_rock.get_version()
LOCAL_ROCK_IMAGE = f"{rock_image}:{rock_version}"

subprocess.run(
[
"docker",
"run",
"--rm",
LOCAL_ROCK_IMAGE,
"exec",
"ls",
"-la",
"/bin/tensorboard-controller",
],
check=True,
)
51 changes: 51 additions & 0 deletions tensorboard-controller/tox.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.
[tox]
skipsdist = True
skip_missing_interpreters = True
envlist = pack, export-to-docker, sanity, integration

[testenv]
setenv =
PYTHONPATH={toxinidir}
PYTHONBREAKPOINT=ipdb.set_trace

[testenv:pack]
passenv = *
allowlist_externals =
rockcraft
commands =
rockcraft pack

[testenv:export-to-docker]
passenv = *
allowlist_externals =
bash
skopeo
yq
commands =
# export rock to docker
bash -c 'NAME=$(yq eval .name rockcraft.yaml) && \
VERSION=$(yq eval .version rockcraft.yaml) && \
ARCH=$(yq eval ".platforms | keys | .[0]" rockcraft.yaml) && \
ROCK="$\{NAME\}_$\{VERSION\}_$\{ARCH\}.rock" && \
DOCKER_IMAGE=$NAME:$VERSION && \
echo "Exporting $ROCK to docker as $DOCKER_IMAGE" && \
skopeo --insecure-policy copy oci-archive:$ROCK docker-daemon:$DOCKER_IMAGE'

[testenv:sanity]
passenv = *
deps =
pytest
charmed-kubeflow-chisme
commands =
# run rock tests
pytest -s -v --tb native --show-capture=all --log-cli-level=INFO {posargs} {toxinidir}/tests

[testenv:integration]
passenv = *
allowlist_externals =
echo
commands =
# TODO: Implement integration tests here
echo "WARNING: This is a placeholder test - no test is implemented here."

0 comments on commit 4684e55

Please sign in to comment.