-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pvcviewer-controller
rock
#130
Conversation
user: ubuntu | ||
|
||
parts: | ||
security-team-requirement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update security requirement, example: https://github.com/canonical/kserve-rocks/blob/main/agent/rockcraft.yaml#L21
mkdir -p ${CRAFT_PART_INSTALL}/usr/share/rocks | ||
(echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > ${CRAFT_PART_INSTALL}/usr/share/rocks/dpkg.query | ||
|
||
pvcviewer-controller: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To stay consistent I recomment building like this https://github.com/canonical/kubeflow-rocks/blob/main/admission-webhook/rockcraft.yaml#L41 with proper environment
Hi @TakoB222 before we proceed we approval of this PR can you please make sure the rock is working with existing charm. You can do it by running integration tests from the pvc viewer repo.
All the tests should be green. After successfully running the tests please can you provide the output of |
Closing this as a duplicate of #154 |
Description