Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pvcviewer-controller rock #130

Closed
wants to merge 3 commits into from
Closed

Conversation

TakoB222
Copy link
Contributor

@TakoB222 TakoB222 commented Sep 6, 2024

Description


  • Add rockcraft.yaml
  • Add tests
  • Add tox

@TakoB222 TakoB222 requested a review from a team as a code owner September 6, 2024 13:17
user: ubuntu

parts:
security-team-requirement:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir -p ${CRAFT_PART_INSTALL}/usr/share/rocks
(echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > ${CRAFT_PART_INSTALL}/usr/share/rocks/dpkg.query

pvcviewer-controller:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stay consistent I recomment building like this https://github.com/canonical/kubeflow-rocks/blob/main/admission-webhook/rockcraft.yaml#L41 with proper environment

@misohu misohu mentioned this pull request Oct 17, 2024
@misohu
Copy link
Member

misohu commented Oct 23, 2024

Hi @TakoB222 before we proceed we approval of this PR can you please make sure the rock is working with existing charm. You can do it by running integration tests from the pvc viewer repo.

  1. Deploy microk8s 1.29-strict/stable
  2. Connect it with juju 3.4/stable
  3. Create kubeflow model
    (if you will have problems with the juju setup please try this step by step guide until model deployment )
  4. publish rock to your dockerhub e.g. tacko/pvc-viewer
  5. In the charm repo replace this line with your rock image from your dockerhub.
  6. Run the tox integration test and keep the model tox -vve integration -- --model kubeflow --keep-models

All the tests should be green. After successfully running the tests please can you provide the output of juju status.
When we develop in our team that is the way how we test that the rock is ready.

@DnPlas
Copy link
Collaborator

DnPlas commented Nov 29, 2024

Closing this as a duplicate of #154

@DnPlas DnPlas closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants