Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor the command to match upstream's #83

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

DnPlas
Copy link
Collaborator

@DnPlas DnPlas commented Apr 18, 2024

The command was incorrectly formatted, resulting in an error: Error: No application module specified.
This commit ensures the command actually runs as it is expected from the upstream image.

Testing instructions

Prerequisites:

  • skopeo
  • docker
  1. Build the rock rockcraft pack -v
  2. Save the rock as an OCI image in docker's local registry skopeo --insecure-policy copy oci-archive:<rock name>.rock docker-daemon:jwa:0.1
  3. Run a container with the image and replace the entrypoint with a shell docker run --rm -ti jwa:0.1
  4. Ensure the service gets started correctly. NOTE: Because the container image needs kubeconfig and proper expose of a the serving port, the output of the command could have the following errors:
kubernetes.config.config_exception.ConfigException: Service host/port is not set.
kubernetes.config.config_exception.ConfigException: Invalid kube-config file. No configuration found.

The command was incorrectly formatted, resulting in an error:
Error: No application module specified.
This commit ensures the command actually runs as it is expected from the upstream image.
@DnPlas DnPlas merged commit 2605035 into main Apr 18, 2024
7 checks passed
@kimwnasptd kimwnasptd deleted the dnplas-fix-command branch April 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants