Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump notebook-controller to 1.9.0-rc.0 #95

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Jun 7, 2024

IIRC we generally do not include the rc part of the tag in the image's version.

Closes #88

@orfeas-k orfeas-k requested a review from a team as a code owner June 7, 2024 10:51
@orfeas-k orfeas-k changed the title chore: bump notebook-controller to v1.9.0-rc.0 chore: bump notebook-controller to 1.9.0-rc.0 Jun 7, 2024
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comments

Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orfeas-k orfeas-k merged commit d701af2 into main Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update notebook-controller ROCK
2 participants