OpenFGA: Add request cache to the OpenFGA datastore #14557
+323
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
reviewed
Nov 29, 2024
markylaing
reviewed
Nov 29, 2024
markylaing
reviewed
Nov 29, 2024
markylaing
reviewed
Nov 29, 2024
markylaing
reviewed
Nov 29, 2024
|
Thanks! Fixing this right away |
gabrielmougard
force-pushed
the
feat/openfga-request-cache
branch
2 times, most recently
from
a4814ce
to
9c61530
Compare
Signed-off-by: Gabriel Mougard <[email protected]>
…name. Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]> Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/openfga-request-cache
branch
from
9c61530
to
2f78972
Compare
|
@tomponline @markylaing updated (thanks Mark for helping documenting this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decrease the latency of API calls that are going through the OpenFGA fine-grained authorizer. Thanks to a per-request cache mechanism, we avoid calling the database when the cache key is present.
This work has been benchmarked and has been used in the following PR: #14476
openfga_benchmark.pdf
The benchmarking script can be found at: https://paste.ubuntu.com/p/WCwsk6gSSK/