Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update storage volume How-to #14578

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

MggMuggins
Copy link
Contributor

This is a first draft of changes I discussed with @minaelee last week. Broadly speaking:

  • Replaces CLI specifications with concrete examples (shift from a generic how to use to more specific/focused tasks). This doesn't entirely turn this into a How-to the diataxis way, but it's closer. CLI specs should be left to --help and the man pages.

  • Convert from the old lxc config set key value to the new lxc config set key=value

  • Misc wording and content improvements

    • align with the current state of LXD (ex. add powerflex)
    • improve precision (ex. s/path for accessing/mount point/ as in mount(8))
  • Move "View storage volumes" to the beginning of the document:
    The first thing I do as a user is ask "how can I see/understand the current state of my system"; only then do I start considering how to mutate that state into what I want.

    Also puts the <volume_type>/<volume_name> syntax front and center; this was a point of confusion for me when I was learning how LXD does storage volumes.

I'd be happy for some feedback on any of this; this is closer to what I would want to use to learn about LXD storage.

@MggMuggins MggMuggins requested a review from minaelee December 4, 2024 02:24
@github-actions github-actions bot added the Documentation Documentation needs updating label Dec 4, 2024
masnax
masnax previously approved these changes Dec 4, 2024
Copy link
Contributor

@masnax masnax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big fan of this, looks a lot clearer!

@MggMuggins MggMuggins dismissed masnax’s stale review December 4, 2024 18:26

The merge-base changed after approval.

doc/howto/storage_volumes.md Outdated Show resolved Hide resolved
doc/howto/storage_volumes.md Outdated Show resolved Hide resolved
@minaelee
Copy link
Contributor

minaelee commented Dec 6, 2024

I'm a big fan of this, looks a lot clearer!

Same, your rewording and additions makes the guide much easier to understand, and huge thumbs-up to adding all the examples!

@tomponline
Copy link
Member

@minaelee @MggMuggins shall we try and address the concerns in #14349 and mention how size is equivalent to quota?


For example, to set the size of your custom storage volume `my-volume` to 1 GiB, use the following command:
To set the size of custom storage volume `my-volume` to 1 GiB, use the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To set the size of custom storage volume `my-volume` to 1 GiB, use the following command:
To set the size (quota) of custom storage volume `my-volume` to 1 GiB, use the following command:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Tom's comment - indicate that quota is another word for size in LXD docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer "To set the maximum size of..." if you agree that it communicates the same idea.

doc/howto/storage_volumes.md Outdated Show resolved Hide resolved
@minaelee
Copy link
Contributor

minaelee commented Dec 7, 2024

@minaelee @MggMuggins shall we try and address the concerns in #14349 and mention how size is equivalent to quota?

Yes, this seems like a great opportunity for that, thanks @tomponline ! Added a couple of suggestions to do so.

This also includes:
- Update config syntax to use `key=value` instead of `key value`
- a number of rewordings, clarifications

Signed-off-by: Wesley Hershberger <[email protected]>
The first thing I do as a user is ask "how can I see/understand the current
state of my system"; only then do I start considering how to mutate that
state into what I want.

This also puts the <volume_type>/<volume_name> syntax front and center.

Signed-off-by: Wesley Hershberger <[email protected]>
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit cda6153 into canonical:main Dec 11, 2024
25 checks passed
@MggMuggins MggMuggins deleted the update-storage-docs branch December 11, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants