-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports (stable-5.21) #14581
Draft
tomponline
wants to merge
328
commits into
canonical:stable-5.21
Choose a base branch
from
tomponline:stable-5.21
base: stable-5.21
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Backports (stable-5.21) #14581
+10,858
−1,572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Stephens <adam@valkor.net> (cherry picked from commit 714d3cdf5b1a9511b0a8305c070f5aea0d99dadc) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit 0e0c58a)
Signed-off-by: Adam Stephens <adam@valkor.net> (cherry picked from commit 459e9e315373517e0b26fd0ee7bbb91306aabe59) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit 49f1aa7)
Signed-off-by: Adam Stephens <adam@valkor.net> (cherry picked from commit 7b359e934edc6f3b170176f44f71e54ba2f638f7) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit f171b15)
Signed-off-by: Adam Stephens <adam@valkor.net> (cherry picked from commit 8ce2a3c7c09e7ae67e180c1fbe6a879bc21a5f9a) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit 732bd1e)
Signed-off-by: Adam Stephens <adam@valkor.net> (cherry picked from commit 06949bf3468105e8500fabfc839662a9d29059dd) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit 8c6dfed)
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 6786970433f10fcd8687d8a3e50315444ef95965) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit e7c8b54)
Closes lxc/incus#377 Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 3f9dd3bfe21d5a31eb810d21f47aafdde4ed61f0) Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> License: Apache-2.0 (cherry picked from commit d9765e7)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 582b2cc)
This is useful to help classify endpoints based on their URL by establishing the preffixes related to each relevant entity type. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit dac2f59)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 7c61616)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 4388a18)
This defines the possible request result types for the API rates metrics and defines the operations to update and retrieve these metrics' values. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit a1999f2)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit bb95903)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 14459aa)
This counts each requested handled by a handler as started for the API metrics and also injects the callback function on the request context. The callback function is used to track the request as completed and can only be run at most once. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit e4d3b84)
Handlers created by `createCmd` will track requests for the API metrics when dealing with endpoints from the main API. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit af29d20)
The `/` endpoint handler and the handler for not found endpoints should be included on the metrics. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 55b3425)
The new `request` parameter is used instead of the request field defined in some Response types that already use request information on `Render`. The `String` function on `forwardedResponse` has to be updated but it is never actually called and exists to satisfy the interface. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 9df5822)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit a094cbe)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 2fe07be)
This is useful to mark the request that spawned that operation as completed when the operation is done. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit bf45467)
Uses the callback function when the operation finishes to mark the request that sapwned the operation as completed. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 65a47e4)
As a consequence of the introduction of the parameter on Render. Those fields have become obsolete and should be substituted and removed. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 98d7060)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit b5e9232)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 84202b3)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit abc502d)
This ensures that: 1. Internal metrics are not cached and are always updated. Before this change, the new values were computed but only the older cached values were included in the endpoint output. 2. Internal metrics are included when there are no instances on the default project. That happened because if no instances were present, the metric set for the default project would not be initialized and thus the internal metrics wouldn't have a set to be included in. This is included on this PR so that the tests won't fail due to the metrics' values not being updated quick enough. Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 6232690)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit f6e4f99)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit 5b84209)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com> (cherry picked from commit d421346)
This commit adds `cmpInstanceAllKeys()` to provide all possible instance config keys for `lxc profile set <profile>` completions. Function names and go doc comments have also been reworded for clarity. Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com> (cherry picked from commit e36d363)
…lation Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> (cherry picked from commit a2324dc)
Signed-off-by: Mark Bolton <mark.bolton@canonical.com> (cherry picked from commit 669fc6f)
Signed-off-by: Mark Laing <mark.laing@canonical.com> (cherry picked from commit a8f95c5)
…ken is used. Signed-off-by: Mark Laing <mark.laing@canonical.com> (cherry picked from commit efb7028)
…identities. Signed-off-by: Mark Laing <mark.laing@canonical.com> (cherry picked from commit f20f62d)
Signed-off-by: Mark Laing <mark.laing@canonical.com> (cherry picked from commit 86b65fe)
Consolidate this to a function rather than sprinkling const "global" all over the place. Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit 2878c2a)
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit a586c1f)
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit 3f49b3a)
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit a4b9cfe)
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit 4b47681)
This records the Raft term & index of the cluster member's global DB in the logs for use during recovery. Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit 76c9c9b)
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit 5e6e651)
Since MicroCloud is GA now Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com> (cherry picked from commit 9379532)
Signed-off-by: Joel Lau <joellau@protonmail.com> (cherry picked from commit 4fec134)
Compilation fails on armhf without this change. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> (cherry picked from commit ad7cb82)
Signed-off-by: Minae Lee <minae.lee@canonical.com> (cherry picked from commit 4cfee29)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit 827aab1)
…error to warning Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit a28082d)
Instead of using a hardcoded NVIDIA driver root path, let's use a recently introduced NVIDIA_DRIVER_ROOT environment variable. Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> (cherry picked from commit fa50b67)
Signed-off-by: Din Music <din.music@canonical.com> (cherry picked from commit fbf993c)
Signed-off-by: Din Music <din.music@canonical.com> (cherry picked from commit 3e35eb1)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> (cherry picked from commit 309f982)
Use 24-hour format instead of 12-hour. Based on comment: canonical@4b26fc2#commitcomment-148595914 Signed-off-by: Din Music <din.music@canonical.com> (cherry picked from commit cc38020)
Signed-off-by: Din Music <din.music@canonical.com> (cherry picked from commit 3045ddd)
github-actions
bot
added
Documentation
Documentation needs updating
API
Changes to the REST API
5.21 LTS
labels
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.