Storage: Per project image and backup storage options #14582
Conversation
Signed-off-by: Mark Bolton <[email protected]>
Signed-off-by: Mark Bolton <[email protected]>
Signed-off-by: Mark Bolton <[email protected]>
Signed-off-by: Mark Bolton <[email protected]>
Signed-off-by: Mark Bolton <[email protected]>
Signed-off-by: Mark Bolton <[email protected]>
github-actions
bot
added
Documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Create images and backups directories, and symlink to the daemon path by default. | ||
| imageDaemonPath := shared.VarPath("images", "daemon", fmt.Sprintf("project_%s", project.Name)) | ||
| imageSymPath := shared.VarPath("images", fmt.Sprintf("project_%s", project.Name)) | ||
| err = os.MkdirAll(imageDaemonPath, 0700) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if err != nil { | ||
| return response.InternalError(fmt.Errorf("Failed to create directory %q: %w", imageDaemonPath, err)) | ||
| } | ||
| err = os.Symlink(imageDaemonPath, imageSymPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if err != nil { | ||
| return response.InternalError(fmt.Errorf("Failed to create directory %q: %w", imageDaemonPath, err)) | ||
| } | ||
| err = os.Symlink(imageDaemonPath, imageSymPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| backupsSymPath := shared.VarPath("backups", fmt.Sprintf("project_%s", project.Name)) | ||
| backupsCustomPath := filepath.Join(backupsSymPath, "custom") | ||
| backupsInstancesPath := filepath.Join(backupsSymPath, "instances") | ||
| err = os.MkdirAll(backupsDaemonPath, 0700) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if err != nil { | ||
| return response.InternalError(fmt.Errorf("Failed to create directory %q: %w", backupsDaemonPath, err)) | ||
| } | ||
| err = os.Symlink(backupsDaemonPath, backupsSymPath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if err != nil { | ||
| return response.InternalError(fmt.Errorf("Failed to create directory %q: %w", backupsCustomPath, err)) | ||
| } | ||
| err = os.MkdirAll(backupsInstancesPath, 0700) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if err != nil { | ||
| return fmt.Errorf("Failed to create the new symlink at %q: %w", shared.VarPath(storageType), err) | ||
| // Create the new symlink. | ||
| err = os.Symlink(destPath, shared.VarPath(storageType, "daemon")) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| } | ||
|
|
||
| // Create the new symlink. | ||
| err = os.Symlink(destPath, shared.VarPath(storageType, fmt.Sprintf("project_%s", projectName))) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if err != nil { | ||
| return fmt.Errorf("Failed to create the new symlink at %q: %w", shared.VarPath(storageType), err) | ||
| // Create the new symlink. | ||
| err = os.Symlink(destPath, shared.VarPath(storageType, "daemon")) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| } | ||
|
|
||
| // Create the new symlink. | ||
| err = os.Symlink(destPath, shared.VarPath(storageType, fmt.Sprintf("project_%s", projectName))) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
This PR adds support for per-project image and backup storage options. We maintain the option to select storage options at the server level, and add a more fine-grained option to select this at the project level.
TODO: Add overview of implementation