Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(subnets): show error message if IP is already reserved/used MAASENG-3516 #5502

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat(subnets): show error message if IP is already reserved/used MAASENG-3516 #5502

merged 1 commit into from
Jul 18, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jul 17, 2024 •
edited by jira bot
Loading

Done

  • "Reserve static DHCP lease" form will now check if an IP is:
    • Already reserved
    • In use by another node

QA steps

Make sure you have a backend that supports reserved IPs (ping me if you need one)

  • Go to subnet/[id]/address-reservation
  • Click "Reserve static DHCP lease"
  • Enter an IP address that has already been reserved
  • Press "Tab" or click away from the field
  • Ensure an error message is displayed
  • In another tab, go to subnet/[id]/used-ip-addresses
  • Enter one of these IP addresses into the form
  • Ensure an error message is displayed

Fixes

Fixes MAASENG-3516

Screenshots

Design

image

@ndv99 ndv99 requested a review from tmerten July 17, 2024 11:43
@webteam-app
Copy link

Demo

Jenkins

demos.haus

tmerten
tmerten approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ndv99 ndv99 merged commit 3cc9cbd into canonical:main Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmerten tmerten tmerten approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndv99 @webteam-app @tmerten