Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(machines): Increase width of bond and bridge forms in Network tab #5504

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(machines): Increase width of bond and bridge forms in Network tab #5504

merged 1 commit into from
Jul 19, 2024

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jul 19, 2024

Done

  • Increased side panel width for:
    • "Create bond" form
    • "Create bridge" form
    • "Edit bond" form

QA steps

  • Go to a machine with at least two interfaces
  • Go to the network tab
  • Select one interface and click "Create bridge"
  • Ensure the side panel width is larger than default, and displays the table with minimal truncation
  • Close the form, select two interfaces and click "Create bond"
  • Ensure the side panel width is larger than default, and displays the table with minimal truncation
  • Fill out the form and submit it
  • Open the "Edit bond" form in the table
  • Ensure the side panel width is larger than default, and displays the table with minimal truncation

Fixes

Fixes lp2073575

Screenshots

Before

image

After

image

@webteam-app
Copy link

Demo

Jenkins

demos.haus

r00ta
r00ta approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@r00ta r00ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ndv99 ndv99 merged commit 450bbac into canonical:main Jul 19, 2024
9 checks passed
ndv99 added a commit to ndv99/maas-ui that referenced this pull request Jul 19, 2024
@ndv99
fix(machines): Increase width of bond and bridge forms in Network tab (…
c9f7f7f 
…canonical#5504)

- Increased side panel width for:
    - "Create bond" form
    - "Create bridge" form
    - "Edit bond" form
---
Resolves [lp2073575](https://bugs.launchpad.net/maas-ui/+bug/2073575)
@ndv99 ndv99 mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00ta r00ta r00ta approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndv99 @webteam-app @r00ta @tmerten