Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subnets): Use PrefixedIpInput in Reserve Range form MAASENG-3524 #5508

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Jul 25, 2024

Done

  • Integrated PrefixedIpInput into the "Reserve Range" and "Reserve Dynamic Range" forms

QA steps

  • Go to a subnet's "Address reservation" page
  • Open the "Reserve range" form
  • Ensure the immutable octets of that subnet's IP are shown correctly
  • Enter some non-numeric text and ensure an error is shown
  • Enter an out-of-range IP address and ensure an error is shown
  • Submit the form and ensure the new reserved range appears correctly in the table
  • Go to a VLAN and open the "Reserve range" form
  • Ensure normal text input fields are used
  • Enter some non-numeric text and ensure an error is shown

Fixes

Fixes MAASENG-3524

Screenshots

Before

image

After

image

@webteam-app
Copy link

Copy link
Contributor

@amylily1011 amylily1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ndv99 ndv99 merged commit e5a7660 into canonical:main Aug 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants