-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Fixed trivial spelling error in keyring placeholder text #5555
Conversation
DEmmons is not a collaborator of the repo |
Everyone contributing to this PR have now signed the CLA. Thanks! |
Hey @DEmmons, thanks for the PR! This looks good to me, but I think you need to use your Canonical email address for your commit signatures in order for it to detect your CLA status (I'm assuming you've signed it a while ago now 😅 ) |
Thanks! Launchpad does show it as signed. I changed the signing email in the commit, and re-pushed it (that's the forceful one), but that hasn't gotten me unstuck here. If I have to scrap this and try again, that's ok, and of course a part of the value in doing this was the learning and ensuring things are set up well on my end, in the hopes that I can make more substantial contributions in the future. I'll try a few more things first, though, before I delete this. |
...it was something just as simple: I had used my email instead of github / launchpad username when I pushed |
Glad you figured it out, nice one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done
QA steps
Fixes
Fixes:
https://bugs.launchpad.net/maas-ui/+bug/2085803
Screenshots
Notes