Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fixed trivial spelling error in keyring placeholder text #5555

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

DEmmons
Copy link
Contributor

@DEmmons DEmmons commented Oct 28, 2024

Done

  • Edited the placeholder text, changing it from "e.g. /usr/share/keyrings/ubuntu-clooudimage-keyring.gpg" to "e.g. /usr/share/keyrings/ubuntu-cloudimage-keyring.gpg"

QA steps

  • navigate to the Change Source dialogue for custom images
  • click on "advanced"
  • verify the placeholder text is correct

Fixes

Fixes:

https://bugs.launchpad.net/maas-ui/+bug/2085803

Screenshots

Notes

Screenshot from 2024-10-28 17-18-08

@webteam-app
Copy link

DEmmons is not a collaborator of the repo

Copy link

github-actions bot commented Oct 28, 2024

Everyone contributing to this PR have now signed the CLA. Thanks!

@DEmmons DEmmons changed the title Fixed trivial spelling error in keyring placeholder text -style: Fixed trivial spelling error in keyring placeholder text Oct 28, 2024
@DEmmons DEmmons changed the title -style: Fixed trivial spelling error in keyring placeholder text style: Fixed trivial spelling error in keyring placeholder text Oct 28, 2024
@ndv99
Copy link
Contributor

ndv99 commented Oct 29, 2024

Hey @DEmmons, thanks for the PR! This looks good to me, but I think you need to use your Canonical email address for your commit signatures in order for it to detect your CLA status (I'm assuming you've signed it a while ago now 😅 )

@DEmmons
Copy link
Contributor Author

DEmmons commented Oct 29, 2024

Thanks! Launchpad does show it as signed. I changed the signing email in the commit, and re-pushed it (that's the forceful one), but that hasn't gotten me unstuck here. If I have to scrap this and try again, that's ok, and of course a part of the value in doing this was the learning and ensuring things are set up well on my end, in the hopes that I can make more substantial contributions in the future. I'll try a few more things first, though, before I delete this.

@DEmmons
Copy link
Contributor Author

DEmmons commented Oct 29, 2024

...it was something just as simple: I had used my email instead of github / launchpad username when I pushed

@ndv99
Copy link
Contributor

ndv99 commented Oct 30, 2024

Glad you figured it out, nice one!

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndv99 ndv99 merged commit 6f4d066 into canonical:main Oct 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants