Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Add retry for metrics endpoint assertion #139

Closed
wants to merge 3 commits into from
Closed

fix(tests): Add retry for metrics endpoint assertion #139

wants to merge 3 commits into from

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Dec 2, 2024 •
edited
Loading

Fix #138

Note that I reran the CI multiple times without hitting the issue while we hit it 2 out of 3 in #136.

@orfeas-k orfeas-k requested a review from a team as a code owner December 2, 2024 13:18
NohaIhab
NohaIhab reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this works, do you think the retry should be added to chisme rather? The assert_metrics_endpoint function is being widely used, and I think the wait is reasonable for all use cases. WDYT?

@orfeas-k
Copy link
Contributor Author

Closing in favor of #145 (see #138)

@orfeas-k orfeas-k closed this Dec 12, 2024
@orfeas-k orfeas-k deleted the kf-6630-fix-metrics-endpoint-tests branch December 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab left review comments

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_metrics_endpoint fails to confirm metrics target
2 participants
@orfeas-k @NohaIhab