Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integration tests #7

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

claudiubelu
Copy link
Contributor

For the integration tests, we're deploying k8s and deploy the webhook present in this repository. We then tests various scenarios in which the webhook should act or not.

One of the integration tests runs a rock with a readOnlyRootFilesystem security context and ensures that it starts properly with this webhook.

@claudiubelu claudiubelu requested a review from a team as a code owner August 27, 2024 13:17
@claudiubelu claudiubelu force-pushed the adds-integration-tests branch 2 times, most recently from 11e671d to 86c73d1 Compare August 28, 2024 07:34
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise looks good

For the integration tests, we're deploying k8s and deploy the webhook
present in this repository. We then tests various scenarios in which the
webhook should act or not.

One of the integration tests runs a rock with a readOnlyRootFilesystem
security context and ensures that it starts properly with this webhook.
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 6618a5d into canonical:main Aug 28, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants