Changes rock base to bare #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
switch-to-bare
branch
from
2dd2478
to
77650f6
Compare
Switching to a bare-based image will reduce the overall image size and reduces attack surface area. Adding the ``CGO_ENABLED=0`` will result in the go binary being statically linked, which means it won't need the ``/lib`` and ``/lib64`` folders to run. This allows us to switch the base image to bare, greatly reducing the image size. Adds an extra sanity check during the integration test, making sure that there is no error reported in Pebble while starting the service.
claudiubelu
force-pushed
the
switch-to-bare
branch
from
77650f6
to
f30b986
Compare
maci3jka
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to a bare-based image will reduce the overall image size and reduces attack surface area.
Adding the
CGO_ENABLED=0will result in the go binary being statically linked, which means it won't need the/liband/lib64folders to run. This allows us to switch the base image to bare, greatly reducing the image size.Adds an extra sanity check during the integration tests, making sure that there is no error reported in Pebble while starting the service.