chore: rework the useAuth hook #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayra1
force-pushed
the
react-components
branch
from
8219568
to
83ca7fe
Compare
gruyaume
requested changes
Nov 26, 2024
There was a problem hiding this comment.
I am (sometimes) getting this error after clicking logout. It seems to happen when I'm on the "Users" page when logging out.
Logs
NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
at 354-6e0ed2af89a87bf1.js:1:289289
at oP (4bd1b696-d2e2b461159d0368.js:1:81871)
at ir (4bd1b696-d2e2b461159d0368.js:1:100512)
at ie (4bd1b696-d2e2b461159d0368.js:1:99775)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99907)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at ie (4bd1b696-d2e2b461159d0368.js:1:99837)
at it (4bd1b696-d2e2b461159d0368.js:1:99973)
at uf (4bd1b696-d2e2b461159d0368.js:1:124786)
at o (4bd1b696-d2e2b461159d0368.js:1:120959)
at MessagePort.T (517-f5f5803271fec325.js:1:107437)
There was a problem hiding this comment.
this is weird, it only happens when the table in either page has more than 0 items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change reworks the useAuth hook so that the rest of the application does not have to use cookies directly. This means that all user login and logout functionality can be used through the useAuth hook. This includes logging in, logging out, initializing first user and checking if the first user is initialized. It also includes caching function definitions and disables queries right up until when the cookie loads into the browser, so it should feel much snappier to use the application.
Checklist: