Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kf 4927 fix update UI config #314

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

i-chvets
Copy link
Contributor

@i-chvets i-chvets commented Nov 1, 2023

Fixes: #312

Summary of changes:

  • Updated Jupyter UI charm config to point to updated ROCKs.

Related PR: canonical/kubeflow-rocks#61

i-chvets and others added 6 commits March 28, 2023 09:30
* fix: add default value for pipelines
canonical/kfp-operators#159

Fixes #159 

Summary of changes:
- Added back default value for pipelines access.
- Added tests for default values of pipelines access and images for 1.7
  release.
- Modified code to check for mindspore image only not version.

---------

Co-authored-by: Andrew Scribner <[email protected]>
#312

Summary of changes:
- Updated Jupyter UI charm config to point to updated ROCKs.
@i-chvets i-chvets requested a review from a team as a code owner November 1, 2023 15:48
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with the 1.7 bundle
LGTM
let's promote to 1.7/stable after this

@kimwnasptd kimwnasptd merged commit 9b689af into track/1.7 Nov 16, 2023
14 checks passed
@kimwnasptd kimwnasptd deleted the kf-4927-fix-update-ui-config branch November 16, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants