Skip to content

Commit

Permalink
feat: avoid use job result from callable workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
zhijie-yang committed Nov 21, 2024
1 parent 619d3bf commit fae67c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/Continuous-Testing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ jobs:
last_scan="$(date --date='26 hours ago' +'%Y-%m-%dT%H:%M:00Z')"
echo "date=$last_scan" >> "$GITHUB_OUTPUT"
run-tests:
name: Run tests for released images
needs: [prepare-test-matrix]
Expand All @@ -46,9 +44,6 @@ jobs:
date-last-scan: ${{ needs.prepare-test-matrix.outputs.last-scan }}
secrets: inherit




issue:
runs-on: ubuntu-22.04
name: Create issue
Expand All @@ -57,7 +52,6 @@ jobs:
- run-tests
env:
GITHUB_TOKEN: ${{ secrets.ROCKSBOT_TOKEN }}
if: ${{ !cancelled() && github.event_name != 'pull_request' }}
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -127,7 +121,6 @@ jobs:
fi
- name: Close issue
if: ${{ needs.run-tests.result == 'success' && steps.issue-exists.outputs.issue-exists == 'true' && steps.create-markdown.outputs.vulnerability-exists == 'false' }}
if: ${{ steps.create-markdown.outputs.vulnerability-exists == 'false' && steps.issue-exists.outputs.issue-exists == 'true' && steps.create-markdown.outputs.vulnerability-exists == 'false' }}
run: |
gh issue close ${{ steps.issue-exists.outputs.issue-number }} --repo ${{ steps.get-image-repo.outputs.img-repo }}
1 change: 0 additions & 1 deletion .github/workflows/Vulnerability-Scan.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,4 +199,3 @@ jobs:
do
MM_CHANNEL_ID="${channel}" ./src/notifications/send_to_mattermost.sh
done

0 comments on commit fae67c6

Please sign in to comment.