Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alertmanager rock #41

Merged
merged 4 commits into from
Aug 22, 2023
Merged

feat: add alertmanager rock #41

merged 4 commits into from
Aug 22, 2023

Conversation

lucabello
Copy link
Collaborator

@lucabello lucabello commented Aug 16, 2023

Ping the @canonical/rocks team.


Description

This PR adds the Alertmanager ROCK to the oci-factory.

Please note that this should go to a new alertmanager repository that's yet to be created. There currently exists a prometheus-alertmanager repository, but that one should be deprecated.

Related issues

#42

@cjdcordeiro cjdcordeiro self-assigned this Aug 18, 2023
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep them coming :D

Just a small typo to fix, but it LGTM ;)

oci/alertmanager/documentation.yaml Outdated Show resolved Hide resolved
@lucabello
Copy link
Collaborator Author

Fixed, thanks!

@cjdcordeiro cjdcordeiro merged commit 82ace21 into canonical:main Aug 22, 2023
14 checks passed
@cjdcordeiro
Copy link
Collaborator

@lucabello this image also failed the efficiency and vulnerability tests-> https://github.com/canonical/oci-factory/actions/runs/5940848690/job/16110358625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants