Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rockcraft file for new rockcraft conventions #9

Merged
merged 1 commit into from
Dec 5, 2023
Merged

update rockcraft file for new rockcraft conventions #9

merged 1 commit into from
Dec 5, 2023

Conversation

ca-scribner
Copy link
Contributor

@ca-scribner ca-scribner commented Dec 4, 2023 •
edited
Loading

  • replaces : in base with @
  • replaces _ in versions with -

@ca-scribner ca-scribner requested a review from a team as a code owner December 4, 2023 19:53
NohaIhab
NohaIhab approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ca-scribner ca-scribner mentioned this pull request Dec 5, 2023
Open
3 tasks
@ca-scribner ca-scribner merged commit 399c9c1 into main Dec 5, 2023
@ca-scribner ca-scribner deleted the update-rock-1.7 branch December 5, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ca-scribner @NohaIhab