Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config values for CSI images #12

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Add config values for CSI images #12

merged 2 commits into from
Jun 21, 2024

Conversation

mateoflorido
Copy link
Member

Overview

Introduce configuration options for the CSI images.

Rationale

We need to provide configurable options for the CSI images in the Helm chart. This pull request introduces a way to specify the image, tag, and repository for the CSI images required by the rawfile-localpv chart.

Copy link

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM!

Copy link

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please address comments

deploy/charts/rawfile-csi/Chart.yaml Outdated Show resolved Hide resolved
deploy/charts/rawfile-csi/values.yaml Outdated Show resolved Hide resolved
deploy/charts/rawfile-csi/templates/01-node-plugin.yaml Outdated Show resolved Hide resolved
@mateoflorido mateoflorido merged commit 3ef9362 into main Jun 21, 2024
3 checks passed
@mateoflorido mateoflorido deleted the KU-1017/csi-images branch June 21, 2024 18:23
addyess pushed a commit that referenced this pull request Jun 21, 2024
Add values for configuring the CSI images in the chart
mateoflorido added a commit that referenced this pull request Jun 21, 2024
* Add config values for CSI images (#12)

Add values for configuring the CSI images in the chart

* Fix Node Driver Registrar Value

---------

Co-authored-by: Adam Dyess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants