Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup helm chart releases site #4

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

addyess
Copy link

@addyess addyess commented Feb 1, 2024

Add Job to build helm charts on pushes to rockcraft branch

Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall, some small comments.

.github/workflows/release_charts.yaml Outdated Show resolved Hide resolved
.github/workflows/release_charts.yaml Outdated Show resolved Hide resolved
@addyess
Copy link
Author

addyess commented Feb 6, 2024

@berkayoz
is the cr.yaml necessary as well?

@berkayoz
Copy link
Member

berkayoz commented Feb 6, 2024

@addyess
Not unless you want to change the default release name. Especially to not have conflicts if the project name is the same as the helm chart name, so we can have 2 types of releases. One for the project itself binaries etc, and a separate one for helm charts.

@addyess
Copy link
Author

addyess commented Feb 6, 2024

@berkayoz cool, i'm ready to test if you are

@berkayoz berkayoz merged commit 7016135 into rockcraft Feb 7, 2024
3 checks passed
@berkayoz berkayoz deleted the KU-277-create-rawfile-localpv-chart-release-job branch February 7, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants