Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(lxd): test newer releases #182

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

tests(lxd): test newer releases #182

wants to merge 4 commits into from

Conversation

thp-canonical
Copy link
Contributor

This will probably fail until #178, #179 and #181 are merged.

@thp-canonical
Copy link
Contributor Author

#184 contains a similar fix.

ZeyadYasser
ZeyadYasser reviewed Mar 20, 2024
View reviewed changes
Copy link

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! just a tiny nitpick but I think that tests/lxd/task.yaml needs to be updated to reflect testing the added releases? This might need also updating tests/lxd/checks/main/task.yaml to include $SPREAD_SYSTEM in the output.

@ZeyadYasser ZeyadYasser mentioned this pull request Mar 20, 2024
Open
thp-canonical and others added 2 commits March 28, 2024 09:09
@thp-canonical
Revert "tests(lxd): test newer releases"
28c9e8a 
This reverts commit 59026ab.
@bboozzoo @thp-canonical
tests/lxd: add Ubuntu 18.04, 20.04, 22.04
88f669d 
Extend the list of systems.

Signed-off-by: Maciej Borzecki <[email protected]>
@thp-canonical
Copy link
Contributor Author

Changed this to contain only the single commit from @bboozzoo that's already in #184.

ZeyadYasser
ZeyadYasser approved these changes Mar 28, 2024
View reviewed changes
Copy link

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

ZeyadYasser
ZeyadYasser reviewed Mar 28, 2024
View reviewed changes
tests/lxd/task.yaml Outdated Show resolved Hide resolved
@thp-canonical thp-canonical mentioned this pull request Mar 28, 2024
Open
@thp-canonical @ZeyadYasser
Update tests/lxd/task.yaml
0b91d65 
Co-authored-by: Zeyad Yasser <[email protected]>
@cmatsuoka
Copy link
Collaborator

This is included in #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyadYasser ZeyadYasser ZeyadYasser approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thp-canonical @cmatsuoka @ZeyadYasser @bboozzoo