Fix $@ vs $* in MATCH and similar functions #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variables $@ and $* differ subtly in how they are expanded. - $* expands to a single value with all the arguments of the program or function joined with spaces, or by the first character of the $IFS variable, to be precise. Usually $* is used in messages where the individual arguments and their count is irrelevant. - $@ is just like $*, _except_ when in double-quoted string "$@". This form expands to multiple values, properly quoted, so that one set of arguments can be passed safely and correctly into another function. The aforementioned macros, FATAL, ERROR, MATCH and NOMATCH all used $@ where $* was expected, and thus only really worked with a single value. The case of MATCH and NOMATCH is more subtle, as usually a single pattern is provided. In general, $* should be used in those cases as $@ does not really do anything different in the error case (the message is the same) but the code is somewhat on the edge of correctness so I chose to adjust them as well. Signed-off-by: Zygmunt Krynicki <[email protected]>
zyga
force-pushed
the
fix/dollar-start-dolar-at
branch
from
9be753a to
e5f269d
Compare
zyga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variables
$@and$*differ subtly in how they are expanded.$*expands to a single value with all the arguments of the program or function joined with spaces, or by the first character of the$IFSvariable, to be precise.Usually
$*is used in messages where the individual arguments and their count is irrelevant.$@is just like$*, except when in double-quoted string"$@". This form expands to multiple values, properly quoted, so that one set of arguments can be passed safely and correctly into another function.The aforementioned macros,
FATAL,ERROR,MATCHandNOMATCHall used$@where$*was expected, and thus only really worked with a single value.The case of
MATCHandNOMATCHis more subtle, as usually a single pattern is provided. In general,$*should be used in those cases as$@does not really do anything different in the error case (the message is the same) but the code is somewhat on the edge of correctness so I chose to adjust them as well.