Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The command 'juju show-cloud' does not support JSON format #249

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

zhhuabj
Copy link
Contributor

@zhhuabj zhhuabj commented Sep 19, 2024

The PR #228 [1] changed to use jq instead of sed to parse yaml when relocating two lines. However, yaml format is not supported in versions prior to juju 3.x.

$ juju show-cloud localhost --format json
ERROR invalid value "json" for option --format: unknown format "json"

Therefore, we need to revert back to the previous two lines to support both juju 2.x and juju 3.x simultaneously.

[1] #228

The PR canonical#228 [1] changed to use jq instead of sed to parse yaml
when relocating two lines. However, yaml format is not supported
in versions prior to juju 3.x.

$ juju show-cloud localhost --format json
ERROR invalid value "json" for option --format: unknown format "json"

Therefore, we need to revert back to the previous two lines
to support both juju 2.x and juju 3.x simultaneously.

[1] canonical#228
Copy link

@jrodrigu-canonical jrodrigu-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected in Juju 2.9.50 and Juju 3.5.3. Looks good to me.

@dosaboy dosaboy merged commit 221e116 into canonical:main Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants