Fix upload octavia script #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianphaley
reviewed
Dec 6, 2024
|
|
||
| set -x | ||
|
|
||
| ID=$(openstack image show --format value --column id jammy) |
There was a problem hiding this comment.
My only enhancement here would be to have the script accept an optional argument - focal/jammy/noble/etc, but default to jammy if none is given.
There was a problem hiding this comment.
I added a command line option for the series.
nicolasbock
force-pushed
the
critical-sparrow
branch
5 times, most recently
from
55c4076 to
e8ff91f
Compare
brianphaley
approved these changes
Dec 10, 2024
dosaboy
reviewed
Dec 11, 2024
There was a problem hiding this comment.
This hasnt been necessary in my experience and I believe that is because as long as you have a Jammy and Focal image in Glance (which I think we always do by default?) then the retrofit charm discovers the image it needs and therefore does not require any arguments when running the action.
Perhaps you could describe what exactly this is fixing in the commit message?
The current version fails with the following error: ```console $ ./tools/upload_octavia_amphora_image.sh Running operation 5 with 1 task - task 6 on unit-octavia-diskimage-retrofit-0 Waiting for task 6... Action id 6 failed: unable to find suitable source image ``` Signed-off-by: Nicolas Bock <[email protected]>
nicolasbock
force-pushed
the
critical-sparrow
branch
from
e8ff91f to
e874020
Compare
|
The command is failing with: $ ./tools/upload_octavia_amphora_image.sh
Running operation 5 with 1 task
- task 6 on unit-octavia-diskimage-retrofit-0
Waiting for task 6...
Action id 6 failed: unable to find suitable source imageI updated the commit message. |
nicolasbock
commented
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicolas Bock [email protected]