-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Synapse backup s3-integration #139
Merged
javierdelapuente
merged 23 commits into
main
from
ISD-1492-Synapse-Create-S3-configuration-for-backup
Jan 22, 2024
Merged
Add Synapse backup s3-integration #139
javierdelapuente
merged 23 commits into
main
from
ISD-1492-Synapse-Create-S3-configuration-for-backup
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbartz
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left some comments.
Co-authored-by: Christopher Bartz <[email protected]>
Co-authored-by: Christopher Bartz <[email protected]>
cbartz
reviewed
Jan 18, 2024
amandahla
reviewed
Jan 18, 2024
amandahla
reviewed
Jan 18, 2024
amandahla
reviewed
Jan 18, 2024
arturo-seijas
approved these changes
Jan 22, 2024
amandahla
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for ccd2406
Static code analysis report
|
javierdelapuente
deleted the
ISD-1492-Synapse-Create-S3-configuration-for-backup
branch
January 22, 2024 16:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: ISD095
Overview
This PR creates a new integration with S3 with the goal of being able to create, list, restore
and delete backups. Those tasks will be done in future PRs. In this one the goal is
to create the integration with a simple test to check that the bucket exists when s3-integration
is integrated with Synapse. All this functionality will be refined in the next PRs.
Rationale
Backups will me stored in S3, so the integration is needed.
Juju Events Changes
on_credentials_changed
andon_credentials_gone
from thecharms.data_platform_libs.v0.s3
library.Module Changes
New module
backup
that will handle backup functionality and will use S3 credentials.Library Changes
Added
charms.data_platform_libs.v0.s3
library.Checklist
src-docs
urgent
,trivial
,complex
)