-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workload version to juju status #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
reviewed
Aug 10, 2023
amandahla
changed the title
WIP - Add workload version to juju status
Add workload version to juju status
Aug 10, 2023
Generally speaking, raising an exception within a function and then handling it within the same function is confusing for the reader and indicates opportunities to improve the error handling flow in a function |
Test coverage for e7d0af5
Static code analysis report
|
jdkandersson
approved these changes
Aug 18, 2023
weiiwang01
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Synapse version to the workload version so the user can check using the
juju status
command.The version can be obtained through a request to the API.
The workload version is set on config-change event for a particular reason: when the charm is deployed, waits for a server_name config. So the user must set by using "juju config synapse server_name=foo". There is a retry configuration because Synapse is restarted after the change.
What happens after merging it: