-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAML integration #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Force restart then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 69 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
38 | 1 | 30 | 0 |
Click to see the invalid file list
- synapse_rock/attributemaps/u1staging.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small questions, 🎉 LGTM!
Test coverage for 84f761e
Static code analysis report
|
Tested with the change merged on this PR canonical/saml-integrator-operator#37
This PR adds SAML integration by using the SAML Integrator charm library.
What happens after merging it: